Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Import gd s #994

Merged
merged 15 commits into from
Jan 27, 2025
Merged

FIX: Import gd s #994

merged 15 commits into from
Jan 27, 2025

Conversation

gkorompi
Copy link
Collaborator

No description provided.

@gkorompi gkorompi changed the title Import gd s FIX: Import gd s Jan 23, 2025
Copy link
Collaborator

@gfetsis gfetsis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are currently at 25R1 version. What is the status with support of previous versions? The proposed changes will affect AEDT versions <23R2

fyi @svandenb-dev

@github-actions github-actions bot added the testing Anything related to testing label Jan 23, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 80.43478% with 9 lines in your changes missing coverage. Please review.

Project coverage is 82.67%. Comparing base (aba86f0) to head (b39f508).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #994      +/-   ##
==========================================
- Coverage   82.68%   82.67%   -0.01%     
==========================================
  Files         160      160              
  Lines       21132    21166      +34     
==========================================
+ Hits        17473    17499      +26     
- Misses       3659     3667       +8     

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jan 24, 2025
@gkorompi gkorompi requested a review from gfetsis January 24, 2025 09:48
Copy link
Collaborator

@svandenb-dev svandenb-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@svandenb-dev svandenb-dev merged commit 58ca21e into main Jan 27, 2025
29 of 30 checks passed
@svandenb-dev svandenb-dev deleted the import_gd_s branch January 27, 2025 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation testing Anything related to testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants